Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: more documentation updates #2818

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Chore: more documentation updates #2818

merged 10 commits into from
Feb 22, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Feb 21, 2024 •
edited
Loading

Description

Documentation only changes found while testing other Pull requests and trying to better understand Victory.

  • Fixes some broken links which pointed to missing .js files
  • Updates some URLs to point to the nearform commerce website

Type of Change

  • This change requires a documentation update

How Has This Been Tested?

  • When reviewing, I clicked on all the links to ensure they went to the new nearform commerce site
  • Verified preview deployment works as expected

Checklist: (Feel free to delete this section upon completion)

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 887a143

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 4:52pm

Sawyer Burnett added 2 commits February 21, 2024 15:35
readme updates
d666dd1 
use new nearform url
use https for links
remove strikethrough comment
use new url for package.json
66136b6
carbonrobot
carbonrobot previously approved these changes Feb 22, 2024
View reviewed changes
@carbonrobot carbonrobot self-requested a review February 22, 2024 16:32
@Burnett2k Burnett2k merged commit efeaea1 into main Feb 22, 2024
9 checks passed
@Burnett2k Burnett2k deleted the react-native-docs-cleanup branch February 22, 2024 17:00
This was referenced May 25, 2024
Open
Open
@TheSimplestUserName TheSimplestUserName mentioned this pull request Jul 23, 2024
Open
@TheSimplestUserName TheSimplestUserName mentioned this pull request Sep 13, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonrobot carbonrobot carbonrobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Burnett2k @carbonrobot