Fix Uncache viewhelper outside of extbase #1898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression from v7.0.0 update: Accessing some ViewHelpers (e.g. f:translate) within an uncache template would otherwise cause an exception
In case there is no Extbase ControllerContext, do not convert ServerRequest to Extbase Request. Instead, attach the ServerRequest directly to the RenderingContext
|
Fixes errors in our TYPO3 v12 projec. @NamelessCoder It would be great if this could be merged |
|
Thanks for the pull request! However, as you can see from the PHPStan reported problems, changing the request resolving method reveals several other ViewHelpers which would not be compatible with a returned ServerRequest. So I rolled all of that into a combined fix which fixes this particular error plus all potential errors coming from use outside of an Extbase context. See 28768f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1894 and a Typo3 v10 regression that came with the release of 7.0.0