Adding support for OSX 10.14.6 build:18G2022 #341
Conversation
| ) | ||
|
|
||
| # when I ran "./CoreDisplay-patcher.command" this was the post-output of "./CoreDisplay-patcher.command md5" | ||
| # otool CoreDisplay: 450241a06a439cd226c9e9cf5cf634d7 |
There was a problem hiding this comment.
I can confirm the same hash and value:
otool -t CoreDisplay2 |tail -n +2 |md5 -q
450241a06a439cd226c9e9cf5cf634d7
hexdump CoreDisplay | grep -i "31 DB 90 90 90 90 90 90 E9"
00187c0 20 31 db 90 90 90 90 90 90 e9 8a 07 00 00 49 89
The current code on master appears to be wrong though as far as I can tell, see #343
Are you sure your code signing is working properly?
I've found out that the script silently discards all code signing errors and potentially leaves you with a broken file.
What is your output from
sudo codesign -f -s - $CoreDisplayLocation
There was a problem hiding this comment.
d4f2aca73c7915c639dbe9a7b9cf5ecd is unlikely to be a proper value though, this is the same one I saw in #343
There was a problem hiding this comment.
I agree with this, I patched my PR
|
Also as far as I'm aware there are no actual builds or any other factors involved in the patching, unless they somehow effect the hash of the original source : this is just debug output to go allow with the MD5. This is just a find/replace string, it will produce identical output every time from identical input. The reason you have a different has is probably because the original PR that was merged was invalid, it should always produce the same hash for the same version of Mac OS or at least the same input hash of otool. |
|
I agree with your previous comment on the wrong md5, and updated the command for two builds that worked also with me |
No description provided.