Ensure the standalone CS listener on Linux uses the SO_REUSEADDR socket option #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyemanov
changed the title
AlexPeshkoff
approved these changes
Jul 12, 2024
dyemanov
added a commit
that referenced
this pull request
Jul 13, 2024
dyemanov
added a commit
that referenced
this pull request
Jul 13, 2024
dyemanov
added a commit
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent FB versions Classic on Linux uses its native listener instead of xinetd/systemd. While we usually don't expect it to crash, it's still possible. However, often it cannot continue listening the port immediately after restart because the port is still in the
FIN_WAITstate and theSO_REUSEADDRsocket option is not used by the standalone Classic listener, thus causing "address already in use" errors during startup. This patch ensures that any kind of listeners (SS/SC usingSRVR_multi_threadand CS standalone server) uses theSO_REUSEADDRoption to avoid the issue.Maybe (after this patch) we should also cleanup the retry loop for
INET_ADDR_IN_USEused later in this function, as it's likely to be pointless, but I leave it for another day.