Allow to configure Firebird in posix using relative directories with options --with-fb* #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options --with-fb*. Relative directories will be interpreted based in the runtime root prefix.
AlexPeshkoff
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
@asfernandes Do you plan to have it in RC2? If yes contact @dyemanov right now - tag to be set very soon.
|
I would like to have it in v5 then next RC would be good. I'll first commit this to master, then let's see what @dyemanov thinks. |
asfernandes
added a commit
that referenced
this pull request
Dec 13, 2023
…options --with-fb*. (#7918) Relative directories will be interpreted based in the runtime root prefix.
dyemanov
reviewed
Dec 14, 2023
src/common/utils.cpp
Outdated
| gds__prefix(tmp, s.c_str()); | ||
| return tmp; | ||
| } | ||
| else |
There was a problem hiding this comment.
Should it be in (the outdated) doc/README.coding.style?
It's not there and personally I think it makes things less readable.
|
I don't see any problems with backport into v5, provided it happens today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative directories will be interpreted based in the runtime root prefix.