CPP-782 Add nodemon plugin #176
Conversation
ivomurrell
force-pushed
the
nodemon-plugin
branch
from
b810d65
to
a1326fc
Compare
There was a problem hiding this comment.
Very excited for this to release, thanks!
I haven't done an in-depth review but, while I was investigating how you got this working, I spotted a few potential issues/improvements. Please don't consider the nitpick to be blocking, as tbh it could come down to tool kit code style which I'm not familiar with.
| }) | ||
| const nodemonLogger = this.logger.child({ process: 'nodemon' }) | ||
| nodemon.on('log', (msg) => { | ||
| function nodemonToWinstonLogLevel(level: string): string { |
There was a problem hiding this comment.
nitpick: I don't think this will have a particularly negative impact if it's not addressed, but this function is redefined each time nodemon logs. It's maybe a bit of a micro-optimisation to move it out of here though so happy if you want to ignore.
There was a problem hiding this comment.
I have a habit of embedding throwaway functions like this right next to the code that uses it so that you don't have to jump around too much when reading the code. It's the kind of thing that I'd hope V8 will optimise away at runtime though, especially when it's not even using any closure state! Maybe that's too optimistic haha I have no idea about the engine's internals
ivomurrell
force-pushed
the
nodemon-plugin
branch
from
a1326fc
to
3eb2d96
Compare
ivomurrell
force-pushed
the
nodemon-plugin
branch
from
d060a41
to
daf908d
Compare
There was a problem hiding this comment.
it looks good to @leannecornish-ft and I, we have a couple of non blocking nitpicks but this is good to merge
This plugin provides a task that can be used in place of the Node plugin and will restart the running process if there are file changes in the directory or if the process exits unexpectedly. Will respect the configuration specified in a nodemon.json in $CWD or $HOME.
Allow users to override the location of the nodemon config from its default location in either the $PWD or $HOME directory.
ivomurrell
force-pushed
the
nodemon-plugin
branch
from
daf908d
to
f56a8ba
Compare
This plugin provides a task that can be used in place of the Node plugin and will restart the running process if there are file changes in the directory or if the process exits unexpectedly. Will respect the configuration specified in a
nodemon.jsonin$CWD,$HOME, or the location specified by theconfigPathoption.I figured there was big enough difference in code to justify splitting this out into a new module rather than just being an option you could toggle in a
.toolkitrc.yml. Splitting the plugins also means that we do not force consumers to install thenodemonpackage when they just want to install the Node plugin.