Fixes on permission validator

FherStk · Dec 16, 2019 · 50cca6a · 50cca6a
1 parent 81a201e
commit 50cca6a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/Program.cs b/Program.cs
@@ -24,7 +24,7 @@ static void Main(string[] args)
         {
             Utils.BreakLine();
             Utils.Write("Automated Assignment Validator: ", ConsoleColor.Yellow);                        
-            Utils.WriteLine("v1.2.4.3");
+            Utils.WriteLine("v1.2.5.0");
             Utils.Write(String.Format("Copyright © {0}: ", DateTime.Now.Year), ConsoleColor.Yellow);            
             Utils.WriteLine("Fernando Porrino Serrano. Under the AGPL license (https://github.com/FherStk/ASIX-DAM-M04-WebAssignmentValidator/blob/master/LICENSE)");
 

diff --git a/src/PermissionsValidator.cs b/src/PermissionsValidator.cs
@@ -16,7 +16,7 @@ public static void ValidateAssignment(string server, string database, bool oldVe
 
                 List<string> currentErrors;
                 List<string> globalErrors;
-                ClearResults();
+                ClearResults(conn);
 
                 //question 1
                 if(oldVersion) success+=1;    //Yes... I know... At least I removed it on the new version...
@@ -155,9 +155,14 @@ public static void ValidateAssignment(string server, string database, bool oldVe
                 Utils.PrintScore(success, errors);                
             }        
         }  
-        private static void ClearResults(){
+        private static void ClearResults(NpgsqlConnection conn){
             success = 0;
             errors = 0;
+
+            //TODO: create the roles (rrhhadmin, prodadmin, dbadmin) and the user (it) if them not exists; also set the default permissions
+            using (NpgsqlCommand cmd = new NpgsqlCommand("REVOKE rrhhadmin FROM dbadmin; REVOKE prodadmin FROM dbadmin;", conn)){
+                cmd.ExecuteNonQuery();                                            
+            }  
         } 
         private static void ProcessResults(List<string> list, int score = 1){
             if(list.Count == 0) success+=score;