Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid suggestion for String#formatted with Locale #380

Closed
Luro02 opened this issue Jan 18, 2024 · 0 comments · Fixed by #394
Closed

Invalid suggestion for String#formatted with Locale #380

Luro02 opened this issue Jan 18, 2024 · 0 comments · Fixed by #394
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Jan 18, 2024

Summary

See below

Lint Name

USE_STRING_FORMATTED

Reproducer

String value = String.format(Locale.US, ROUTE_NUMBER_STRING, getRouteNumber(), start.getName(), destination.getName(), this.price);

which suggests

Locale.US.formatted(ROUTE_NUMBER_STRING, getRouteNumber(), start.getName(), destination.getName(), this.price)
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels Jan 18, 2024
@Luro02 Luro02 mentioned this issue Jan 18, 2024
Closed
Luro02 added a commit to Luro02/autograder that referenced this issue Jan 23, 2024
@Luro02
emit exactly one formatted message and ignore String.format with Locale
bc2d60f 
Feuermagier#380
@Luro02 Luro02 mentioned this issue Jan 23, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement some things Luro02/autograder
1 participant
@Luro02