feat: add rpm artifacts #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #34 @FelicianoTech let me know if you need any additional info / feedback etc. |
|
@altanunsal Apologies for the delay. If you're still interested, if you can just do a rebase. The |
|
Closing due to lack of response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RPM artifacts to build
CircleCI on my fork generated the artifacts https://app.circleci.com/pipelines/github/altanunsal/pocket-casts-desktop-app/4/workflows/55f88095-c99a-45ff-b8b1-77c233e42b56
Key changes
@electron-forge/maker-rpmas a dev dependencyrpmpackage in the docker image sorpmbuildcli is available for electron-forgeTODO
Consider creating a rpm repository via COPR: https://docs.fedoraproject.org/en-US/quick-docs/publish-rpm-on-copr/