Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exactly sampler #5637

Open
wants to merge 3 commits into
base: develop-1.11.5
Choose a base branch
from

Conversation

sagewe
Copy link
Contributor

@sagewe sagewe commented Jun 25, 2024

No description provided.

Signed-off-by: sagewe <wbwmat@gmail.com>
self._sample[randint - 1] = obj

return self._sample

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[autopep8] reported by reviewdog 🐶

Suggested change

Signed-off-by: sagewe <wbwmat@gmail.com>
@@ -197,3 +179,58 @@ def subtractByKey(self, other: "Table"):
@computing_profile
def union(self, other: "Table", func=lambda v1, v2: v1):
return Table(self._table.union(other._table, func))

def _exactly_sample(table: Table, num, seed):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[autopep8] reported by reviewdog 🐶

Suggested change
def _exactly_sample(table: Table, num, seed):
def _exactly_sample(table: Table, num, seed):

self._sample[randint - 1] = obj

return self._sample

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[autopep8] reported by reviewdog 🐶

Suggested change

Signed-off-by: sagewe <wbwmat@gmail.com>
@dylan-fan dylan-fan changed the base branch from develop-1.11.5 to main-1.x July 26, 2024 09:53
@dylan-fan dylan-fan self-requested a review July 26, 2024 09:53
@dylan-fan dylan-fan changed the base branch from main-1.x to develop-1.11.5 July 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant