Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docstrings and Updated manual_control.py #73

Merged
merged 10 commits into from
Nov 4, 2022

Conversation

BolunDai0216
Copy link
Collaborator

@BolunDai0216 BolunDai0216 commented Oct 30, 2022

Description

  • Added docstrings to all of the environments.
  • Updated manual_control.py to work with the new render(), step() and reset()

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts
Copy link
Member

Looks good to me, @BolunDai0216 Do you want me to merge?

@BolunDai0216
Copy link
Collaborator Author

Looks good to me, @BolunDai0216 Do you want me to merge?

Yes, you can merge it.

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 5f82a00 into Farama-Foundation:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants