24w34a porting fixes #4054
Merged
24w34a porting fixes #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thrown tridents are handled in a different method to ensure they do not break after successful use (you cannot throw tridents that are almost broken). To make the API simple (as you cannot use this with vanilla items anyway), exclude them from coverage.
apple502j
added
bug
modmuss50
approved these changes
Aug 26, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: there is a bug that is causing durability-less custom elytra to not function (as seen in testmod). I believe this affects 1.20.5 and above; if this is to be fixed it will be in a separate PR.