Refactoring printers #3425
Merged
Refactoring printers #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, the pretty printer and ugly printer are interconnected and sometimes hard to update. Plus, the ugly printer's output is parsed by Vale, so it must adhere to a given shape which makes it hard to update, or to do other changes (e.g. see the need for this patch be3f709 in #3406).
This PR separates them and moves to using typeclasses almost everywhere. Next, I will do a Vale printer so we can fully isolate the output needed by Vale. But this is a big change already and I'd like to merge it.
Please report if you find any error messages have changed for the worse.