Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OCaml version to 4.14 #3397

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Bump OCaml version to 4.14 #3397

merged 5 commits into from
Aug 28, 2024

Conversation

gebner
Copy link
Contributor

@gebner gebner commented Aug 24, 2024

I just tried installing F* on a new machine and opam installed --deps-only . failed with this error:

# [...]
# (cd _build/default && /home/gebner/.opam/default/bin/ocamlc.opt -w -40 -w -3-32-50-52 -g -bin-annot -I src/.batteries_unthreaded.objs/byte -I /home/gebner/.opam/default/lib/camlp-streams -I /home/gebner/.opam/default/lib/num -intf-suffix .ml -no-alias-deps -o src/.batteries_unthreaded.objs/byte/batGc.cmo -c -impl src/batGc.pp.ml)
# File "src/batGc.pp.ml", line 1:
# Error: The implementation src/batGc.pp.ml
#        does not match the interface src/.batteries_unthreaded.objs/byte/batGc.cmi:
#        The value `get_minor_free' is required but not provided
#        File "src/batGc.mli", line 278, characters 0-61: Expected declaration
# (cd _build/default && /home/gebner/.opam/default/bin/ocamlopt.opt -w -40 -w -3-32-50-52 -g -I src/.batteries_unthreaded.objs/byte -I src/.batteries_unthreaded.objs/native -I /home/gebner/.opam/default/lib/camlp-streams -I /home/gebner/.opam/default/lib/num -intf-suffix .ml -no-alias-deps -o src/.batteries_unthreaded.objs/native/batGc.cmx -c -impl src/batGc.pp.ml)
# File "src/batGc.pp.ml", line 1:
# Error: The implementation src/batGc.pp.ml
#        does not match the interface src/.batteries_unthreaded.objs/byte/batGc.cmi:
#        The value `get_minor_free' is required but not provided
#        File "src/batGc.mli", line 278, characters 0-61: Expected declaration

From what I can tell, recent versions of batteries no longer build with old OCaml versions. It seems easiest to just bump OCaml to the latest version, which this PR does.

This requires an update of the fstar_ci container image, so this PR fails CI for now.

@gebner gebner merged commit a1397ee into master Aug 28, 2024
0 of 3 checks passed
@gebner gebner deleted the gebner_ocaml414 branch August 28, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant