Misc changes #3167
Merged
Misc changes #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mtzguido
commented
Dec 15, 2023
mtzguido
commented
- Strengthening some specs in tactics
- Better annotations in SMT logs (distinguish val x from let x, most importantly)
- Stabilize hint hashes and regenerate them
Instead of names, which do not let us distinguish between `val`s and `let`s
I recently added some text to the query files to state the versions of F* and Z3 used, but that includes F*'s commit hash which makes the hint hashes invalid after any F* commit. This fixes that problem by using Captions, which get ignored when printing the query for the purpose of computing the hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.