Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tactic fixes #3001

Merged
merged 14 commits into from
Aug 3, 2023
Merged

Tactic fixes #3001

merged 14 commits into from
Aug 3, 2023

Conversation

mtzguido
Copy link
Member

@mtzguido mtzguido commented Aug 2, 2023

Most importantly:

  • join could make goals ill-scoped due to a silly error in longest_prefix, now fixed
  • Each plugin/primitive call now adds an error context to more easily pinpoint an error/crash
  • Goals generated during a %splice were not being checked. Thankfully we almost never use the proofstate on splice calls so there's no impact afaics.
  • A nit on the Makefile to avoid ETXTBSY errors with the make boot rule

mtzguido added a commit to FStarLang/steel that referenced this pull request Aug 2, 2023
@mtzguido
snap for FStarLang/FStar#3001
56e251c
mtzguido added a commit to FStarLang/steel that referenced this pull request Aug 2, 2023
@mtzguido
snap for FStarLang/FStar#3001
2213bfd
@mtzguido mtzguido mentioned this pull request Aug 2, 2023
Merged
@mtzguido mtzguido merged commit 47e325c into master Aug 3, 2023
2 checks passed
@mtzguido mtzguido deleted the guido_tactics branch August 3, 2023 01:23
mtzguido added a commit to FStarLang/steel that referenced this pull request Aug 3, 2023
@mtzguido
Merge pull request #55 from FStarLang/guido_3001
92a12f9 
snap for FStarLang/FStar#3001
mtzguido added a commit to FStarLang/steel that referenced this pull request Aug 7, 2023
@mtzguido
Merge pull request #67 from FStarLang/guido_guardpolicy
967182e 
Prepare for FStarLang/FStar#3001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtzguido