Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: docker fixes & improvements #8263

Merged
merged 2 commits into from
Mar 18, 2021
Merged

tests: docker fixes & improvements #8263

merged 2 commits into from
Mar 18, 2021

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Mar 16, 2021

  • libelf-dev was missing
  • the rsync mechanism didn't support git worktrees (and was unnecessarily complicated)

@polychaeta polychaeta added the tests Topotests, make check, etc label Mar 16, 2021
@NetDEF-CI

This comment has been minimized.

Sign in to view
@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 16, 2021 •
edited
Loading

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8263 11a5713
Date 03/16/2021
Start 04:25:45
Finish 05:05:08
Run-Time 39:23
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-03-16-04:25:45.txt
Log autoscript-2021-03-16-04:26:48.log.bz2
Memory 484 489 431

For details, please contact louberger

@eqvinox
tests: add libelf-dev to Dockerfile
071f5c1 
Signed-off-by: David Lamparter <equinox@diac24.net>
@eqvinox
tests: simplify docker rsync & support worktrees
53abc26 
The previous, more complex mechanism failed to take into account that
git worktrees only have a stub .git file & copying the worktree itself
is not enough.  Just extract a file list beforehand & don't bother with
git inside the container.

Signed-off-by: David Lamparter <equinox@diac24.net>
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Mar 17, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17744/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP3U1804AMD64-17744/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:

2021-03-17 13:29:26,552 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/03/17 13:42:53 BGP: vty[??]@> enable
2021/03/17 13:42:53 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/03/17 13:42:53 BGP: vty[??]@> enable
2021/03/17 13:42:53 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/03/17 13:42:54 BGP: vty[??]@> enable
2021/03/17 13:42:54 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/03/17 13:42:54 BGP: vty[??]@> enable
2021/03/17 13:42:54 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/03/17 13:42:54 BGP: vty[??]@> enable
2021/03/17 13:42:55 BGP: vty[??]@> enable
2021/03/17 13:42:55 BGP: vty[??]@> enable
2021/03/17 13:42:55 BGP: vty[??]@> enable
2021/03/17 13:43:00 BGP: vty[??]@> enable
2021/03/17 13:43:01 BGP: vty[??]@> enable
2021/03/17 13:43:01 BGP: vty[??]@> enable
2021/03/17 13:43:01 BGP: vty[??]@> enable
2021/03/17 13:43:01 BGP: vty[??]@> enable
2021/03/17 13:43:06 BGP: vty[??]@> enable
2021/03/17 13:43:06 BGP: vty[??]@# do write memory


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/03/17 13:44:23 BGP: vty[??]@> enable
2021/03/17 13:44:23 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart json
2021/03/17 13:44:23 BGP: vty[??]@> enable
2021/03/17 13:44:23 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart 
2021/03/17 13:44:23 BGP: vty[??]@> enable
2021/03/17 13:44:23 BGP: vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart json
2021/03/17 13:44:23 BGP: vty[??]@> enable
2021/03/17 13:44:23 BGP: vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart 
2021/03/17 13:44:24 BGP: vty[??]@> enable
2021/03/17 13:44:24 BGP: vty[??]@> enable
2021/03/17 13:44:24 BGP: vty[??]@> enable
2021/03/17 13:44:24 BGP: vty[??]@> enable
2021/03/17 13:44:30 BGP: vty[??]@> enable
2021/03/17 13:44:30 BGP: vty[??]@> enable
2021/03/17 13:44:30 BGP: vty[??]@> enable
2021/03/17 13:44:30 BGP: vty[??]@> enable
2021/03/17 13:44:30 BGP: vty[??]@> enable
2021/03/17 13:44:36 BGP: vty[??]@> enable
2021/03/17 13:44:36 BGP: vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/03/17 13:46:03 BGP: vty[??]@> enable
2021/03/17 13:46:03 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/03/17 13:46:03 BGP: vty[??]@> enable
2021/03/17 13:46:03 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/03/17 13:46:03 BGP: vty[??]@> enable
2021/03/17 13:46:03 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/03/17 13:46:03 BGP: vty[??]@> enable
2021/03/17 13:46:03 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/03/17 13:46:04 BGP: vty[??]@> enable
2021/03/17 13:46:04 BGP: vty[??]@> enable
2021/03/17 13:46:04 BGP: vty[??]@> enable
2021/03/17 13:46:04 BGP: vty[??]@> enable
2021/03/17 13:46:10 BGP: vty[??]@> enable
2021/03/17 13:46:10 BGP: vty[??]@> enable
2021/03/17 13:46:10 BGP: vty[??]@> enable
2021/03/17 13:46:10 BGP: vty[??]@> enable
2021/03/17 13:46:10 BGP: vty[??]@> enable
2021/03/17 13:46:16 BGP: vty[??]@> enable
2021/03/17 13:46:16 BGP: vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/03/17 13:46:31 BGP: vty[??]@(config)# log file bgpd.log
2021/03/17 13:46:31 BGP: vty[??]@> enable
2021/03/17 13:46:31 BGP: vty[??]@# do show logging
2021/03/17 13:46:32 BGP: vty[??]@> enable
2021/03/17 13:46:32 BGP: vty[??]@# do write terminal

2021/03/17 13:46:32 BGP: vty[??]@> enable
2021/03/17 13:46:32 BGP: vty[??]@# configure terminal
2021/03/17 13:46:32 BGP: vty[??]@(config)# XFRR_start_configuration
2021/03/17 13:46:32 BGP: vty[??]@(config)# no log commands

2021/03/17 13:46:33 BGP: bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/03/17 13:46:33 BGP: bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/03/17 13:46:34 BGP: Configuration Read in Took: 00:00:00
2021/03/17 13:46:36 BGP: bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/03/17 13:46:36 BGP: bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/03/17 13:47:07 BGP: Configuration Read in Took: 00:00:00
2021/03/17 13:47:09 BGP: [EC 33554451] bgp_process_packet: BGP OPEN receipt failed for peer: 192.168.0.2
2021/03/17 13:47:10 BGP: bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/03/17 13:47:10 BGP: bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default

r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/03/17 13:48:20 BGP: vty[??]@> enable
2021/03/17 13:48:20 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/03/17 13:48:20 BGP: vty[??]@> enable
2021/03/17 13:48:20 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/03/17 13:48:20 BGP: vty[??]@> enable
2021/03/17 13:48:20 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/03/17 13:48:20 BGP: vty[??]@> enable
2021/03/17 13:48:20 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/03/17 13:48:21 BGP: vty[??]@> enable
2021/03/17 13:48:21 BGP: vty[??]@> enable
2021/03/17 13:48:21 BGP: vty[??]@> enable
2021/03/17 13:48:21 BGP: vty[??]@> enable
2021/03/17 13:48:27 BGP: vty[??]@> enable
2021/03/17 13:48:27 BGP: vty[??]@> enable
2021/03/17 13:48:27 BGP: vty[??]@> enable
2021/03/17 13:48:27 BGP: vty[??]@> enable
2021/03/17 13:48:27 BGP: vty[??]@> enable
2021/03/17 13:48:33 BGP: vty[??]@> enable
2021/03/17 13:48:33 BGP: vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/03/17 13:49:27 BGP: vty[??]@> enable
2021/03/17 13:49:27 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/03/17 13:49:27 BGP: vty[??]@> enable
2021/03/17 13:49:27 BGP: vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/03/17 13:49:27 BGP: vty[??]@> enable
2021/03/17 13:49:27 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/03/17 13:49:27 BGP: vty[??]@> enable
2021/03/17 13:49:27 BGP: vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/03/17 13:49:28 BGP: vty[??]@> enable
2021/03/17 13:49:28 BGP: vty[??]@> enable
2021/03/17 13:49:28 BGP: vty[??]@> enable
2021/03/17 13:49:28 BGP: vty[??]@> enable
2021/03/17 13:49:34 BGP: vty[??]@> enable
2021/03/17 13:49:34 BGP: vty[??]@> enable
2021/03/17 13:49:34 BGP: vty[??]@> enable
2021/03/17 13:49:34 BGP: vty[??]@> enable
2021/03/17 13:49:34 BGP: vty[??]@> enable
2021/03/17 13:49:40 BGP: vty[??]@> enable
2021/03/17 13:49:40 BGP: vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/03/17 13:49:54 BGP: [EC 100663299] buffer_flush_available: write error on fd 2: Bad file descriptor
2021/03/17 13:49:54 BGP: vty[??]@> enable
2021/03/17 13:49:54 BGP: vty[??]@# configure terminal
2021/03/17 13:49:54 BGP: vty[??]@(config)# log commands
2021/03/17 13:49:54 BGP: vty[??]@(config)# log file bgpd.log
2021/03/17 13:49:55 BGP: vty[??]@> enable
2021/03/17 13:49:55 BGP: vty[??]@# do show logging
2021/03/17 13:49:55 BGP: vty[??]@> enable
2021/03/17 13:49:55 BGP: vty[??]@# do write terminal

2021/03/17 13:49:56 BGP: vty[??]@> enable
2021/03/17 13:49:56 BGP: vty[??]@# configure terminal
2021/03/17 13:49:56 BGP: vty[??]@(config)# XFRR_start_configuration
2021/03/17 13:49:56 BGP: vty[??]@(config)# no log commands

2021/03/17 13:49:56 BGP: bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/03/17 13:49:56 BGP: bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/03/17 13:49:57 BGP: Configuration Read in Took: 00:00:00
2021/03/17 13:50:00 BGP: bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/03/17 13:50:00 BGP: bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17744/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 16.04 i386 part 0
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 16.04 i386 part 1
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 amd64 part 2
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 16.04 i386 part 9
  • Topotests Ubuntu 16.04 amd64 part 2
  • Topotests Ubuntu 16.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Debian 9 deb pkg check
  • Topotests Ubuntu 16.04 i386 part 3
  • Topotests Ubuntu 16.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 16.04 amd64 part 9
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 8
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 16.04 amd64 part 8
  • Debian 8 deb pkg check
  • Topotests Ubuntu 16.04 i386 part 4
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 16.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 16.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 16.04 amd64 part 3
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Static analyzer (clang)
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 16.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 16.04 i386 part 5
  • Topotests Ubuntu 16.04 amd64 part 4
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 16.04 amd64 part 7
  • Topotests Ubuntu 16.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 16.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 16.04 amd64 part 1
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 0

@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 17, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8263 53abc26
Date 03/17/2021
Start 12:54:55
Finish 13:34:13
Run-Time 39:18
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-03-17-12:54:55.txt
Log autoscript-2021-03-17-12:56:02.log.bz2
Memory 494 502 430

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17744/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit e43ba29 into FRRouting:master Mar 18, 2021
@eqvinox eqvinox deleted the docker-update branch March 22, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eqvinox @NetDEF-CI @LabN-CI @donaldsharp @polychaeta