bgpd: BGP neighbor password change doesn't take effect with a a particular config on reboot #7432
Conversation
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-byline; we can't accept your contribution until all of your commits have one
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-byline; we can't accept your contribution until all of your commits have one
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/40666c5c228a1f34246a40af19758f13/raw/426e75fb66a4bfa7df6c1b1db9cdc5f0e195cc08/cr_7432_1604148615.diff | git apply
diff --git a/bgpd/bgp_main.c b/bgpd/bgp_main.c
index 03f479033..2eb518c83 100644
--- a/bgpd/bgp_main.c
+++ b/bgpd/bgp_main.c
@@ -265,12 +265,13 @@ static int bgp_vrf_new(struct vrf *vrf)
if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("VRF Created: %s(%u)", vrf->name, vrf->vrf_id);
- zlog_info("VRF Creation message received: %s(%u)", vrf->name, vrf->vrf_id);
+ zlog_info("VRF Creation message received: %s(%u)", vrf->name,
+ vrf->vrf_id);
struct interface *ifp;
ifp = if_get_by_name(vrf->name, vrf->vrf_id);
- if (ifp)
- {
- zlog_info("VRF interface Created: %s(%u) ifindex %d", ifp->name, ifp->vrf_id, ifp->ifindex);
+ if (ifp) {
+ zlog_info("VRF interface Created: %s(%u) ifindex %d", ifp->name,
+ ifp->vrf_id, ifp->ifindex);
}
return 0;
@@ -280,9 +281,10 @@ static int bgp_vrf_delete(struct vrf *vrf)
{
if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("VRF Deletion: %s(%u)", vrf->name, vrf->vrf_id);
- zlog_info("VRF Deletion message received: %s(%u)", vrf->name, vrf->vrf_id);
- /* No need to delete vrf here as it will be deleted when BGP client receives
- ZEBRA_VRF_DELETE message from zebra */
+ zlog_info("VRF Deletion message received: %s(%u)", vrf->name,
+ vrf->vrf_id);
+ /* No need to delete vrf here as it will be deleted when BGP client
+ receives ZEBRA_VRF_DELETE message from zebra */
return 0;
}
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 044587fe9..34f37d091 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -5656,8 +5656,8 @@ int peer_password_set(struct peer *peer, const char *password)
*/
if (BGP_PEER_SU_UNSPEC(peer))
return BGP_SUCCESS;
- ret = (bgp_md5_set(peer) >= 0) ? BGP_SUCCESS
- : BGP_ERR_TCPSIG_FAILED;
+ ret = (bgp_md5_set(peer) >= 0) ? BGP_SUCCESS
+ : BGP_ERR_TCPSIG_FAILED;
/* Send notification or reset peer depending on state. */
if (BGP_IS_VALID_STATE_FOR_NOTIF(peer->status))
bgp_notify_send(peer, BGP_NOTIFY_CEASE,
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15088/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: CentOS 8 amd64 build: Failed (click for details)CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15088/artifact/CENTOS8BUILD/config.status/config.statusPackage building failed for CentOS 8 amd64 build FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15088/artifact/CI009BUILD/config.status/config.status Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
226927b
to
30c02d2
Compare
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-byline; we can't accept your contribution until all of your commits have one
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-byline; we can't accept your contribution until all of your commits have one
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15091/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: CentOS 8 amd64 build: Failed (click for details)CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15091/artifact/CENTOS8BUILD/config.status/config.statusPackage building failed for CentOS 8 amd64 build FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15091/artifact/CI009BUILD/config.status/config.status Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 1 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15090/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64 Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8 Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15090/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64 Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64 Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15090/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 1 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15090/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64 Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8 Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15090/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64 Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64 Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15090/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15090/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15090/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64 Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15092/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64 Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 1 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15092/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8 Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64 Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15092/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15092/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64 Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 1 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15092/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8 Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15092/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64 Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15092/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15092/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64 Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
e88fe45
to
df1cf38
Compare
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-byline; we can't accept your contribution until all of your commits have one
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
df1cf38
to
5ecf03d
Compare
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
5ecf03d
to
3ba2bcd
Compare
I have changed the signed-off-by message and rebased to latest master. Let me know, if anything else is needed. |
|
I accidently closed the pull request. I am reopening it. @donaldsharp : Please approve this commit as I have addressed all your review comments. |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 1 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15103/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15103/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386 Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8 Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15103/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 1 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15103/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64 Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15103/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386 Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64 Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8 Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386 Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8 Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64 Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15103/test Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386 Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15103/test Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64 Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15103/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64 Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 16.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-17491/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16AMD64-17491/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TOPO6U16AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-17491/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-17491/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16I386-17491/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TOPO6U16I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-17491/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16AMD64-17491/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TOPO6U16AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-17491/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-17491/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16I386-17491/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TOPO6U16I386/ErrorLog/log_topotests.txt Addresssanitizer topotests part 5: Incomplete(check logs for details)Topotests Ubuntu 16.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-17491/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17491/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundSuccessful on other platforms/tests
|
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
a9c5594
to
e7d89cc
Compare
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/9a1640e58678f270a353095e65fd9d8d/raw/848d0f29bb14f4c2ac8b61533a7b499585f687d0/cr_7432_1617614928.diff | git apply
diff --git a/bgpd/bgp_main.c b/bgpd/bgp_main.c
index 61952fab4..96c2e130d 100644
--- a/bgpd/bgp_main.c
+++ b/bgpd/bgp_main.c
@@ -279,7 +279,7 @@ static int bgp_vrf_new(struct vrf *vrf)
if (ifp) {
if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("VRF interface Created: %s(%u) ifindex %d",
- ifp->name, ifp->vrf_id, ifp->ifindex);
+ ifp->name, ifp->vrf_id, ifp->ifindex);
}
return 0;
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-18178/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-18178/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16AMD64-18178/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TOPO6U16AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 16.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-18178/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-18178/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16I386-18178/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TOPO6U16I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-18178/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-18178/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16AMD64-18178/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TOPO6U16AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 16.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-18178/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-18178/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16I386-18178/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18178/artifact/TOPO6U16I386/ErrorLog/log_topotests.txt |
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
e7d89cc
to
e6e6bed
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 16.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16I386-18199/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TOPO6U16I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-18199/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-18199/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-18199/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-18199/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16AMD64-18199/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TOPO6U16AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 16.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16I386-18199/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TOPO6U16I386/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-18199/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-18199/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-18199/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TP1U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-18199/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U16AMD64-18199/test Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18199/artifact/TOPO6U16AMD64/ErrorLog/log_topotests.txt |
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
e6e6bed
to
e1e310e
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
e1e310e
to
5b00720
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 16.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1604I386-18222/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18222/artifact/TP4U1604I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 16.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1604I386-18222/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18222/artifact/TP4U1604I386/ErrorLog/log_topotests.txt |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18225/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
|
@ton31337 : Please review this code. |
|
@qlyoung @donaldsharp @ton31337 : Please review the changes. These are minor changes. I had discussed with @mwinter-osr , currently we don't have testcases for reboot scenarios in the mininet framework. |
…cular config on reboot Description: when vrf add is received, add Vrf-name to the interface database. This is needed while binding the VRF interface to the BGP socket. In this case, the global bgp config containing vrf is received before zebra sends vrf add message to BGP. When we receive the global bgp vrf message first, vrf interface is not present in the interface database of BGP. So, while creating the global bgp socket, interface bind to the vrf interface fails. Problem Description/Summary : changing the neighbor password resets the session immediately but it doesn't use the password. It continues to operate without password. Managed to recreate the issue with below reduced config. Setup: Sonic1------Sonic2 Test Steps: 1. Configure eBGP session between Sonic-1 and Sonic2 in default vrf using Peer-group. 2. Create a dummy non-default vrf BGP instance on Sonic1 device. 3. Save and reload Sonic1 device. 4. Once the device is up, try to configure 'password <string>' on Sonic1 BGP neighbor alone. 5. The eBGP session should go down and must not come up until matching password is configured on Sonic2 device. But it comes up. Expected Behavior : The eBGP session should go down and must not come up until matching password is configured on Sonic2 device. Signed-off-by: sudhanshukumar22 <sudhanshu.kumar@broadcom.com>
sudhanshukumar22
force-pushed
the
bgp-vrf-registration-issue
branch
from
5b00720
to
2681e38
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18277/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
|
@ton31337 : Please review and approve the changes. |
There was a problem hiding this comment.
This is not a correct approach to solving this problem. We should not create interfaces manually from BGP. The correct thing is to fix vrf_bind to rely on VRF existence instead of interface existence. #8367 is going to fix this.
There was a problem hiding this comment.
I'm pretty confused about how this fixes the problem.
The root problem is that the VRF doesn't exist and so config for a BGP instance tied to a VRF ends up creating a socket in the default VRF. Any later incorrect behavior that manifests because of this needs to be treated at the source.
Based on how I'm reading this patch, it looks like all we do here is make an interface that has the same name as the VRF that we expect zebra to tell us about in short order. I fail to see how this treats the root of the problem.
Can you elaborate on how exactly this helps things? How does creating an internal interface structure make it so that the password (which is set via a sockopt call) ends up properly applied?
Also cf #8644
|
@qlyoung the author already stated that the vrf_bind PR fixes his use-case and he's going to dismiss this PR: https://github.com/FRRouting/frr/pull/8644/files#r630961190 |
|
Excellent, @sudhanshukumar22 please close this |
|
@qlyoung @idryzhov , thanks, I have tested that my defect works with the fix provided in I was waiting for his PR to be merged. Anyway, will close it now. |
bgpd: BGP neighbor password change doesn't take effect with a a particular config on reboot
Description: when vrf add is received, add Vrf-name to the interface database. This is needed while binding the VRF interface to the BGP socket.
In this case, the global bgp config containing vrf is received before zebra sends vrf add message to BGP. When we receive the global bgp vrf message
first, vrf interface is not present in the interface database of BGP. So, while creating the global bgp socket with vrf, interface bind to the vrf interface fails. This creates a BGP socket without vrf binding(i.e. socket in default VRF). The socket is used by another BGP instance (if present for default VRF) to send out BGP packets.
Problem Description/Summary :
changing the neighbor password resets the session immediately but it doesn't use the password. It continues to operate without password.
Managed to recreate the issue with below reduced config.
Setup:
Sonic1------Sonic2
Test Steps:
Expected Behavior :
The eBGP session should go down and must not come up until matching password is configured on Sonic2 device.
Signed-off-by: sudhanshukumar22 sudhanshu.kumar@broadcom.com