Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Late registration of Extended Nexthop should allow RA's to happen #3286

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

donaldsharp
Copy link
Member

When we have a late registration of the Extended Nexthop capability
for BGP and the peer already has nexthop information stored, go
through and enable RA on the important interfaces.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 6, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3286 cb8e8ba
Date 11/06/2018
Start 16:01:00
Finish 16:24:57
Run-Time 23:57
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-11-06-16:01:00.txt
Log autoscript-2018-11-06-16:01:46.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5844/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for bgp_nht.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #877: FILE: /tmp/f1-30126/bgp_nht.c:877:

CLANG Static Analyzer Summary

  • Github Pull Request 3286, comparing to Git base SHA 8dfa7e4

No Changes in Static Analysis warnings compared to base

@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 6, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3286 7919a6d
Date 11/06/2018
Start 17:20:39
Finish 17:44:47
Run-Time 24:08
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-11-06-17:20:39.txt
Log autoscript-2018-11-06-17:21:31.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5845/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 3286, comparing to Git base SHA 8dfa7e4

No Changes in Static Analysis warnings compared to base

When we have a late registration of the Extended Nexthop capability
for BGP and the peer already has nexthop information stored, go
through and enable RA on the important interfaces.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 7, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3286 1ea03b9
Date 11/07/2018
Start 14:20:38
Finish 14:44:21
Run-Time 23:43
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-11-07-14:20:38.txt
Log autoscript-2018-11-07-14:21:23.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5851/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 3286, comparing to Git base SHA 8dfa7e4

No Changes in Static Analysis warnings compared to base

@eqvinox eqvinox merged commit 8bed7a8 into FRRouting:master Nov 13, 2018
@donaldsharp donaldsharp deleted the late_registration branch December 5, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants