zebra: Allow dplane to pass larger number of nexthops down to dataplane #17023
+41
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
force-pushed
the
dplane_problems
branch
2 times, most recently
from
f2d5f42
to
9790fa1
Compare
donaldsharp
force-pushed
the
dplane_problems
branch
2 times, most recently
from
089db7b
to
b501ac2
Compare
ton31337
reviewed
Oct 8, 2024
bgpd/bgp_attr.h
Outdated
| @@ -251,7 +251,7 @@ struct attr { | |||
| as_t aggregator_as; | |||
|
|
|||
| /* MP Nexthop length */ | |||
| uint8_t mp_nexthop_len; | |||
| uint16_t mp_nexthop_len; | |||
There was a problem hiding this comment.
Why is this needed? This can't be higher than 48 bytes overall (assuming it's encoded as global + link-local for vpnv6).
There was a problem hiding this comment.
your right I just assumed it was. Sorry, removed
Currently FRR is limiting the nexthop count to a uint8_t not a uint16_t. This leads to issues when the nexthop count is 256 which results in the count to overflow to 0 causing problems in the code. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
donaldsharp
force-pushed
the
dplane_problems
branch
from
b501ac2
to
9f8968f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently FRR is limiting the nexthop count to a uint8_t not a uint16_t. This leads to issues when the nexthop count is 256 which results in the count to overflow to 0 causing problems in the code.