lib: Do not convert EVPN prefixes into IPv4/IPv6 if not needed #15377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert only when this is really needed, e.g. `match ip address prefix-list ...`. Otherwise, we can't have mixed match clauses, like: ``` match ip address prefix-list p1 match evpn route-type prefix ``` This won't work, because the prefix is already converted, and we can't extract route type, vni, etc. from the original EVPN prefix. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Test prefix-list matching and some other EVPN stuff. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2 tasks
|
@taspelund can you take a look at this? This seems to be backing out your routemap change |
|
I've had my head out of the code for a while, but this change seems like it might break prefix-list matching for the IP/IP-prefix within Type-2/5 routes that sworley added a while back. (IIRC I just did some back porting of his code?) If we have tests that confirm that prefix-lists still match IP/IP-Prefix carried by RT-2/5 routes after this change, then I'm okay with it. But it's a nack from me if that functionality is lost |
|
It works with EVPN prefix matching (= Sworley's work works fine, with no breaking changes). |
|
@Mergifyio backport dev/10.0 stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
This was referenced Feb 23, 2024
riw777
added a commit
that referenced
this pull request
Feb 27, 2024
lib: Do not convert EVPN prefixes into IPv4/IPv6 if not needed (backport #15377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.