zebra: Extend the FPM module to push the missing SRv6 nexthop information #12292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `encap_src_addr` parameter to the `struct zebra_srv6`. This parameter represents the source address of the outer encapsulating IPv6 header. Support for configuring the `encap_src_addr`parameter will be added in a future commit. Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
Zebra’s `fpm` module allows allows an external component to learn the forwarding information computed by the FRR routing suite. Currently, the information exported by `fpm` does not include the SRv6 `seg6` nexthops. This commit extends the `fpm` module to push the missing SRv6 `seg6` nexthop information. Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
In this commit, we introduce the ability to specify flags for an SRv6 locator. Flags can be used to specify the properties of the locator. Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
In this commit, we add a new flag to the SRv6 locator called `SRV6_LOCATOR_USID`, which is used to specify a locator as a uSID locator. When the `SRV6_LOCATOR_USID` flag is set, the routing protocols will install SRv6 uSID behaviors in the dataplane. In a future commit, we will extend bgpd to use the SRv6 uSID Endpoint Behavior codepoint in the BGP advertisement when the flag is set. Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
Zebra’s `fpm` module allows allows an external component to learn the forwarding information computed by the FRR routing suite. Currently, the information exported by `fpm` does not include the SRv6 `seg6local` nexthops. This commit extends the `fpm` module to push the missing SRv6 `seg6local` nexthop information. Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log found |
|
ci:rerun |
|
Please modify dplane_fpm_nl.c instead of the old fpm module. New features must be in that module instead. It is the future and the zebra_fpm_nl.c is not the correct place to do this work. |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log found |
|
@donaldsharp Thanks for the suggestion! I ported the changes to the |
|
Closing this PR because we have a better implementation in #12301. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRv6 is supported in SONiC (sonic-net/sonic-swss#1964) as part of release 202211 (~Nov 2021). Zebra’s FPM module allows SONiC to learn the forwarding information computed by the FRR routing suite. Currently, the information exported by FRR does not include the SRv6 nexthops.
We already have two open PRs to support two functionalities required for the integration of FRR and SONiC: #12219 adds the support for SRv6 uSID behaviors to FRR; #12261 adds the missing source address parameter for the SRv6 encapsulation.
This PR completes the integration work of FRR and SONiC by extending the FPM module to push the missing SRv6 nexthop information to SONiC.
Signed-off-by: Carmine Scarpitta carmine.scarpitta@uniroma2.it