Replace NVTX macros with constexpr + namespaced methods #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ranges can be generated from python now:
Might need some tweaking if / when we have a static installable build of the c++ library, as the ENABLED property is just fed from the macro. Not checked this produces the same binaries, that's a much bigger effort to diff than a standalone incomplete MWE. |
ptheywood
force-pushed
the
constexpr-nvtx
branch
from
194f4de
to
8ae6bd9
Compare
mondus
requested changes
Nov 23, 2022
ptheywood
force-pushed
the
constexpr-nvtx
branch
from
8ae6bd9
to
646bcee
Compare
|
Now re-adjusted to:
Needs a squash, but subject to windows specific warnings about unused variables / masking this should be good to re-review. |
ptheywood
force-pushed
the
constexpr-nvtx
branch
from
3d7adce
to
b19fd03
Compare
+ Replaces NVTX_PUSH(label) with flamegpu::util::nvtx::push(label) + Replaces NVTX_POP() with flamegpu::util::nvtx::pop() + Replaces NVTX_RANGE(label) with flamegpu::util::nvtx::Range(label) + Ranges must be assigned to a variable for correct lifetime + Add constexpr bool flamegpu::util::nvtx::ENABLED + Wraps flamegpu::util::nvtx with swig, excluding ranges due to Swig + python GC concerns + Adds pyflamegpu.nvtx_push(lable) + Adds pyflamegpu.nvtx_pop() + Adds pyflamegpu.NVTX_ENABLED + Adds python tests
ptheywood
force-pushed
the
constexpr-nvtx
branch
from
b19fd03
to
7e8d992
Compare
Robadob
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have the same (C++) runtime cost in optimisaed builds
Closes #984