Fix compilation on Bessemer (GCC11?) #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Bessemer/GCC11 has issues if a .cpp file includes both cuda_runtime.h and curand_kernel.h) This has been tested on Bessemer A100s)
Robadob
added a commit
that referenced
this pull request
Jul 6, 2023
..on Windows, leading to nested venvs etc. Have moved from flat-layout to src-layout, so venv dir is not mistakenly included. Closes #988
Robadob
added a commit
that referenced
this pull request
Jul 7, 2023
..on Windows, leading to nested venvs etc. Have moved from flat-layout to src-layout, so venv dir is not mistakenly included. Closes #988
ptheywood
pushed a commit
that referenced
this pull request
Jul 10, 2023
..on Windows, leading to nested venvs etc. Have moved from flat-layout to src-layout, so venv dir is not mistakenly included. Closes #988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux of the issue was that
ModelDescription.hincludesCUDASimulation.cuhandCUDAEnsemble.cuh. This has the knock-on effect of causing cuda headers to get included in a wide number of places unnecessarily, and for some reason Bessmer/GCC11 causes curand to include cuda headers as C rather than C++.Many other files were relying on the
ModelDescription.hinclude hierarchy, so some additional includes had to be added elsewhere.