Automatically trigger __disown__() when Python hostfns are bound to models. #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
force-pushed
the
python_hostfn_outofscope
branch
from
565061c
to
dac2fd7
Compare
mondus
force-pushed
the
python_hostfn_outofscope
branch
from
dac2fd7
to
32db5c4
Compare
mondus
force-pushed
the
python_hostfn_outofscope
branch
from
32db5c4
to
3a56621
Compare
Linux python tests all pass under linux (Release Seatbelts=ON) |
ptheywood
approved these changes
Nov 16, 2022
Robadob
added a commit
that referenced
this pull request
Nov 24, 2022
…ames BugFix: #975 had failed to address addExitCondition()
Robadob
added a commit
that referenced
this pull request
Nov 28, 2022
…ames BugFix: #975 had failed to address addExitCondition()
Robadob
added a commit
that referenced
this pull request
Dec 7, 2022
…ames BugFix: #975 had failed to address addExitCondition()
Robadob
added a commit
that referenced
this pull request
Dec 7, 2022
…ames BugFix: #975 had failed to address addExitCondition()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to trigger the exception, but added a try-catch regardless.
I think I have removed all usages of
__disown__()from the Python tests, checked usinggrep -rnw "tests/" -e "disown".Closes #498