Swig array element unify #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
force-pushed
the
swig_array_element_unify
branch
from
385a255
to
683ebc0
Compare
ptheywood
approved these changes
Oct 3, 2022
Possibly a GH bug, I vaguely recall I initially made this PR point at master and had to update it. |
Does seem it, a local diff for that file shows it's the same in the two branches, so who knows if I've even reviewed the right changes or even all of them.... |
…environment properties. User's are provided the ability to add environment properties/environment array property elements to user interface panel(s) in the form of input boxes, sliders, drag things and checkboxes. Additionally, moved the debug menu to ImGui and added the initial random seed to it's items.
This makes it more consistent with rest of ModelVis methods.
Also unified model naming of examples (in particular Circles Spatial3D was listed as bruteforce).
…ty() element version Also unified API of all other array element methods to have optional 2nd length arg (C++ API). Closes #912
Robadob
force-pushed
the
swig_array_element_unify
branch
from
683ebc0
to
a04688c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have tested C++/Py tests.
Added new Py tests for the missing
CUDASimulationfunctionality.Only test failures were in CodeGen, due to #915