BugFix: ManyLinux CI was not setting BuildNumber inside generated bin #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries This was due to the Git directory being owned by a different user. Have pre-emptivley added the fix to other CI runs which perform a CMake configure/build
ptheywood
approved these changes
Jan 26, 2023
|
Tested the manylinux wheel generated by the pull_request triggered draft_ci workflow: python3 -m pip install pyflamegpu-2.0.0rc1+cuda120-cp310-cp310-linux_x86_64.whl
python3 -c "import pyflamegpu; print(pyflamegpu.VERSION_BUILDMETADATA)"
06b722fThe hash is the post-merge hash due to the pull_request triggger, but actual releases will behave as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build number issue inside ManyLinux CI.
Also pre-emptively apply the fix to most of the other CI jobs (those which do compilation/CMake test)
Relates #1035
Error:
Fixed version: (albeit the
FLAMEGPU_VERSION_BUILDMETADATA:statement has been removed that was for debugging.)