Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py install is deprecated #947

Closed
ptheywood opened this issue Oct 26, 2022 · 0 comments · Fixed by #935
Closed

setup.py install is deprecated #947

ptheywood opened this issue Oct 26, 2022 · 0 comments · Fixed by #935
Assignees
Labels

Comments

@ptheywood
Copy link
Member

ptheywood commented Oct 26, 2022

Spotted the following deprecation warning during pyflamegpu building:

SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.

This seems to have been introdued in setuptools 58.3.0 (22 Oct 2021)

#917: setup.py install and easy_install commands are now officially deprecated. Use other standards-based installers (like pip) and builders (like build). Workloads reliant on this behavior should pin to this major version of Setuptools. See Why you shouldn’t invoke setup.py directly for more background.

I'm not sure what the setuptools removal timeline is, but they're on v65.6.0 now.


We either need to fix this, or pin our setuptools as suggested?


We currently invoke setup.py bdist_wheel via our cmake, to produce the wheels, which impliclty calls install internally.

Using build instead the equivalent call would (probably) be python3 -m build --wheel. The change would also require us to add the pyhton package build as a checked python dependency. There might also need to be some tweaks to the CMake for byproduces etc for correct cleaning.
--wheel is required as we don't care for source distributions sdist (default is sdist and bdist).

build simply requires Python >=3.6, so should be fine to adopt, and is provided/maintained by pypa, so shoudl be supported/maintained for a decent chunk of time.

It'll be easiest to make this change post #935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant