You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Spotted the following deprecation warning during pyflamegpu building:
SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
This seems to have been introdued in setuptools 58.3.0 (22 Oct 2021)
#917: setup.py install and easy_install commands are now officially deprecated. Use other standards-based installers (like pip) and builders (like build). Workloads reliant on this behavior should pin to this major version of Setuptools. See Why you shouldn’t invoke setup.py directly for more background.
I'm not sure what the setuptools removal timeline is, but they're on v65.6.0 now.
We either need to fix this, or pin our setuptools as suggested?
We currently invoke setup.py bdist_wheel via our cmake, to produce the wheels, which impliclty calls install internally.
Using build instead the equivalent call would (probably) be python3 -m build --wheel. The change would also require us to add the pyhton package build as a checked python dependency. There might also need to be some tweaks to the CMake for byproduces etc for correct cleaning. --wheel is required as we don't care for source distributions sdist (default is sdist and bdist).
build simply requires Python >=3.6, so should be fine to adopt, and is provided/maintained by pypa, so shoudl be supported/maintained for a decent chunk of time.
Spotted the following deprecation warning during pyflamegpu building:
This seems to have been introdued in setuptools 58.3.0 (22 Oct 2021)
I'm not sure what the setuptools removal timeline is, but they're on
v65.6.0
now.We either need to fix this, or pin our setuptools as suggested?
We currently invoke
setup.py bdist_wheel
via our cmake, to produce the wheels, which impliclty calls install internally.Using
build
instead the equivalent call would (probably) bepython3 -m build --wheel
. The change would also require us to add the pyhton packagebuild
as a checked python dependency. There might also need to be some tweaks to the CMake for byproduces etc for correct cleaning.--wheel
is required as we don't care for source distributionssdist
(default is sdist and bdist).build
simply requiresPython >=3.6
, so should be fine to adopt, and is provided/maintained by pypa, so shoudl be supported/maintained for a decent chunk of time.It'll be easiest to make this change post #935
The text was updated successfully, but these errors were encountered: