Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable CMake Build types MinSizeRel and RelWithDebInfo #698

Closed
ptheywood opened this issue Oct 1, 2021 · 0 comments · Fixed by #704
Closed

Re-enable CMake Build types MinSizeRel and RelWithDebInfo #698

ptheywood opened this issue Oct 1, 2021 · 0 comments · Fixed by #704

Comments

@ptheywood
Copy link
Member

We currently explicitly set the only build types to Release and Debug in our CMake, removing the other default options of MinSizeRel (-O2) and RelWithDebInfo (-O2 -gopt).

This was to match FLAME GPU 1's available build modes (which also included a profile build mode, but this was removed due to a lack of use).

These can be very useful in some cases (i.e. when there are bugs in release builds only), and as a CMake project it probably makes sense to keep them. They also cause no harm, other than 2 other options being present in drop down boxes in the CMake GUI and Visual Studio GUI.

This will be a simple change if it's agreed to re-enable them, and simply removing a couple of lines of CMake in common.cmake (both here and in the vis repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant