Adjust CMake Logic for GLEW and OpenGL to improve manylinux viability #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ptheywood
commented
Aug 24, 2021
ptheywood
commented
- Use Static GLEW if available and requested via cmake flag
- Use Legacy OpenGL if requested, rather than GLVND on linux
- Might make manylinux compatibility viable
- Might prevent EGL use in the future (when building for manylinux)
- Updates Manylinux CI to make use of these features
+ Use Static GLEW if available and requested via cmake flag
+ Use Legacy OpenGL if requested, rather than GLVND on linux
+ Might make manylinux compatibility viable
+ Might prevent EGL use in the future (when building for manylinux)
+ Updates Manylinux CI to make use of these features
ptheywood
force-pushed
the
static_glew_if_available
branch
from
59c5780
to
e469f72
Compare
4 tasks
|
This commit allows glibc 2.17 wheels which can run visusalistaion on more recent ubuntu versions, but it does not allow manylinux complaint wheels yet. I'm going to merge this in, so I can bump the commit version in a PR in the main repo, so the new CI process can be merged in for generic linux wheels (but not manylinux yet). #78 Might get us towards manylinux compliance, it might not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.