-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another bug with sunion #26
Comments
Location is not in fm2, so that seems normal, no ? No problem for Data. I commited a fix for your test (using FeatureIDE configuration facilities, always because of the problem with SAT4J -- in my setup, we use SAT4J 2.3.2 and so FeatureIDE) |
After the merge the feature Location is in a group optional and that is ok. But, there should be a constraint standing that if Forecast is selected, Location must be selected too, as Location is a mandatory feature in FM1 and Forecast appears only there. So, in the end, when I select Forecast, Location should be automatically selected. |
Fully agree. |
I implement a BDD-based implementation It seems working |
I have another issue with another FM with this implementation. I add a unit test. |
Fixed. |
New unit tests : isValid seems not work with the new implementation. |
Another bug found between internal and syntactic representation. Sorry I didn't found a simple example for the unit test... |
Not sure if this bug is related to the #25
I execute the following script:
s1 = FM(Source: TI Criteria; TI: Forecast; Forecast: Weather2; Criteria: Date Location;)
s2 = FM(Source: TI Criteria; TI: Ephem; Criteria: Date; Date: Beginning; Beginning: Now;)
s3 = FM(Source: TI Criteria; TI: Calendar; Criteria: Location Duration Date;)
smerge = merge sunion s*
c = configuration smerge
select Forecast in c
println c
Given the FM s1 where all is mandatory I expect to obtain
selected [Source, TI, Criteria, Forecast, Weather2, Date, Location] deselected: [Duration, Beginning, Now, Calendar, Ephem]
However I obtain that :
selected: [Source, Date, TI, Weather2, Forecast, Criteria] deselected: [Duration, Beginning, Now, Calendar, Ephem]
Date and Location remain optional
The text was updated successfully, but these errors were encountered: