Adding selfHandleResponse option parameter to Proxy policy
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry I haven't been able to jump on this yet. |
|
@XVincentX that's ok, I'm not even sure this is the best way do implement this, I mean we could just pass the selfHandleResponse to the proxy and expose Take your time, I just think 🙏 |
|
I'm jumping on this again now — I completely lost the context :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
selfHandleResponseand sending the option tonode-http-proxyis important to enable processing responses from proxied backends.Usually
node-http-proxypipes the proxied response through existing response stream. This can be disabled byselfHandleResponse. I supply an implementation suggestion for sending the proxied response through expressres.send().Plugins might monkey patch this method to effectively intercept and handle express gateway responses. As I do in: https://github.com/josemf/express-gateway-plugin-errors.