Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react duplicate keys #35

Closed

Conversation

huzaifa-99
Copy link

Details

In the E/App repo, when adding the same location multiple times for a waypoint, we would get the react duplicate keys error. This pr adds a fix for that.

Related Issues

GH_LINK

Manual Tests

When this branch is merged

  1. In the E/App repo, go to the component where we use the MapView component
  2. Add 2 waypoints that have the same coordinates (use the current location)
  3. Verify you don't see the react duplicate keys error

Linked PRs

Expensify/App#25990

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@huzaifa-99
Copy link
Author

cc: @hayata-suenaga @narefyev91

@huzaifa-99

This comment was marked as off-topic.

@hayata-suenaga
Copy link
Contributor

I asked the author of this PR to include this fix in their PR as we're actually closing the map library and moving all the code over to App.

@huzaifa-99
Copy link
Author

huzaifa-99 commented Aug 31, 2023

Sounds good. Please feel free to close this PR @hayata-suenaga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants