Add workflow for auto publishing the repo to NPM #2
Conversation
| gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output OSBotify-private-key.asc OSBotify-private-key.asc.gpg | ||
| gpg --import OSBotify-private-key.asc | ||
| env: | ||
| LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} |
There was a problem hiding this comment.
Just making sure this secret was added to the repo via Ring0?
There was a problem hiding this comment.
It wasn't, no. Is there anything you'd be able to point me to with instructions on what Ring0 needs to do exactly?
There was a problem hiding this comment.
Here is an example issue: https://github.com/Expensify/Expensify/issues/288197
LARGE_SECRET_PASSPHRASE is in 1Password, so Ring0 will be able to find it.
There was a problem hiding this comment.
OK, thanks. I opened this issue to have them added: https://github.com/Expensify/Expensify/issues/302806
| --body "Update version to ${{ env.NEW_VERSION }}" | ||
| sleep 5 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} |
| gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output OSBotify-private-key.asc OSBotify-private-key.asc.gpg | ||
| gpg --import OSBotify-private-key.asc | ||
| env: | ||
| LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} |
| --body "Update version to ${{ env.NEW_VERSION }}" | ||
| sleep 5 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} |
|
@AndrewGable Any idea what's wrong with the CLA workflow? https://github.com/Expensify/react-native-x-maps/actions/runs/5659066613/job/15331799891 It wasn't failing on the PR where the workflow was added. |
|
I think it's missing this secret too: https://github.com/Expensify/react-native-x-maps/blob/main/.github/workflows/cla.yml#L31 |
There was a problem hiding this comment.
Agree with @luacmartins, let's merge once secrets are added.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
OK, tests are all passing now so I will merge and see what happens with the NPM publishing. |
This PR implements a GitHub workflow that automatically publishes a new version of the library to NPM every time a PR is merged to
main. This flow was copied from react-native-onyx.Tests
None. This can only be tested once it is merged. Then we will see if it works or not!
QA