Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to synchronize operations within one update #490
Try to synchronize operations within one update #490
Changes from 29 commits
b4c739b
e9966f0
9cb563e
c7247ea
1d32cc2
748c51f
d0d261b
44617ed
f537212
c160503
e32f0e3
b56d236
f2513d8
a98aeb1
150a16e
94ec428
b954d72
2796388
10ab402
90473be
3447e6f
a153237
290b4b7
00ddb11
bb3acaa
6fea4d3
918d2e9
47fc3cb
c986e51
3381ff8
31fd63e
e9abdd5
ad25727
4169591
d1b6b95
ca3cd29
8ea4699
28c6d5c
230ef57
c2e6351
153bc79
2f74bfd
45b0523
d11cbd4
873443c
4fabc64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more context to this comment to answer why this needs to happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "later" imply? Can you please update the comment to be more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blazejkustra could you please also suggest a way to avoid using
as any
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blazejkustra this change causes a TS error without
as OnyxKey
– interesting that the initial TS migration PR didn't throw an error here considering the map had the typeMap<OnyxKey, OnyxValue<OnyxKey>>
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of assertion here, let's validate that
collectionValues
is of typestring[]
, we could also just do this: