Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix red spell check line is shown frequently when typing #470

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Sep 6, 2024

Details

This PR fixes the problem with too many input structure re-renders and fixes a problem with red spell check line being added too early, when still typing a word

Screen.Recording.2024-09-06.at.14.53.42.mov

Related Issues

GH_LINK

Manual Tests

  1. Open example app
  2. Start typing any sentence
  3. Verify if the red spell check line isn't shown while still typing a word
  4. Verify if the red spell check line is being added correctly

Linked PRs

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, haven't tested it though

@Skalakid
Copy link
Collaborator Author

Skalakid commented Sep 9, 2024

Before After
before.mov
after.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants