Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Markdown for web follow-up 2 #461

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Aug 28, 2024

Details

In this PR we fix tree length to prevent scenarios when the start and end tree nodes can't be found

Related Issues

Expensify/App#48052

Manual Tests

If you are using iOS simulator, test using iOS keyboard (I/O > Keyboard > Connect hardware keyboard <- set to off)

  1. Install changes in E/App
  2. Enter any chat
  3. in composer enter new line and than in the second line start writing emoji, fe: :hand:
  4. Verify if cursor is positioned correctly

Linked PRs

#394

@Skalakid Skalakid merged commit f060c8e into main Aug 28, 2024
5 checks passed
@Skalakid Skalakid deleted the @Skalakid/refactor-follow-up-v2 branch August 28, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants