Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump expensify-common to 2.0.46 and fix handling br tag #431

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

skyweb331
Copy link
Contributor

@skyweb331 skyweb331 commented Jul 15, 2024

Details

  1. Bump expensify-common to 2.0.46
  2. Add handling <br /> which throws error when there is <br /> tag.

Related Issues

$ Expensify/App#43386

Manual Tests

Linked PRs

$ Expensify/expensify-common#750

Copy link

github-actions bot commented Jul 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@skyweb331
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hungvu193
Copy link

For more context, this PR is a follow-up to Expensify/expensify-common#750, which adds support for multiple lines in email hyperlinks.

cc @tomekzaw for your review.

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomekzaw tomekzaw merged commit 51a5262 into Expensify:main Jul 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants