Add macOS support #149
Draft
Add macOS support #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
visionOS support also coming? :) |
Simek
reviewed
Feb 9, 2024
| @@ -9,6 +9,7 @@ type MarkdownStyle = MarkdownTextInputDecoractorView.MarkdownStyle; | |||
|
|
|||
| const FONT_FAMILY_MONOSPACE = Platform.select({ | |||
| ios: 'Courier', | |||
| macos: 'Courier', | |||
There was a problem hiding this comment.
Suggested change
| macos: 'Courier', | |
| macos: 'SF Mono', |
Can we use SF Mono as default for macOS?
There was a problem hiding this comment.
Sure, thanks for this suggestion! Do we want to stick with Courier on iOS though?
There was a problem hiding this comment.
Done a bit of checking, and looks like SF fonts are not included by default for all systems to this day on both iOS and macOS.
In this case Menlo or Monaco could be a viable alternative for both platforms:
|
Any updates on this one? MacOS support would be huge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Related Issues
GH_LINK
Manual Tests
Linked PRs