Update engines to be less strict #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
rezkiy37
approved these changes
May 8, 2024
|
I believe the merge freeze does not apply here, since we would need to bump the version in App first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updates the engines field to be a bit less strict and match
react-native-onyx: https://github.com/Expensify/react-native-onyx/blob/main/package.json#L112-L114Related Issues
https://github.com/Expensify/Mobile-Expensify/pull/12655
Manual Tests
Once we install the latest version in App we will verify
npm installworks with latest node