Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow starting and ending hyphen in local-style urls #598

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

byte1012
Copy link
Contributor

@byte1012 byte1012 commented Nov 9, 2023

Fixed Issues

$ Expensify/App#27080
Proposal: Expensify/App#27080 (comment)

Tests

  1. Go to any chat.
  2. Type the following valid local-style urls and observe that it's parsed
valid urls
        http://localhost:3000
        https://local.url
        http://a.b
        http://expensify
        http://google.com/abcd
        http://my.localhost.local-domain
  1. Type the following invalid local-style urls and observe that it's not parsed
invalid urls
        localhost:3000
        local.url
        http://-localhost
        http://_
        http://_localhost
        http://-77.com
        http://77-.com
        http://my.localhost....local-domain:8080

QA

Same as tests step

Offline tests

Same as tests step

Screenshots/Videos

Web

image

Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@byte1012 byte1012 requested a review from a team as a code owner November 9, 2023 07:33
Copy link

github-actions bot commented Nov 9, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from lakchote and removed request for a team November 9, 2023 07:33
@byte1012
Copy link
Contributor Author

byte1012 commented Nov 9, 2023

I have read the CLA Document and I hereby sign the CLA

@lakchote lakchote merged commit 5a8993b into Expensify:main Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants