-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Upgrade mbedtls to 3.5.2 #1802
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following all of these changes, are the private SSL changes necessary for the newer version of mbedtls?
Will need to make sure Auth and the other plugins work with this as well, which is why its on hold before we merge |
Yeah they explicitly make sure its accessed internally or externally with private_ prefixes now |
Okay Fuzzybot, ExpensifyTableManager, ExpensifyBackupManager all compile and run with the updated version, so we'll want to merge this first, merge auth, then deploy asap so that auth using the bedrock prod branch doesn't break things |
Approved this, but letting you figure out the required deploy dance. |
Oh do you mind approving https://github.com/Expensify/Auth/pull/11565 as well then? |
Done. |
Is this still held @johnmlee101? |
yes, since this will require a specific deployment order to prevent auth from crashing in tests |
I'm going to be OOO, and I don't think this is too time-sensitive, so I might resume this once I'm back, and since its also Friday I don't want to force a deploy today. |
Turns out 3.6.0 doesn't work with TLS v1.3
Was trying to figure this out for awhile and got errors like Mbed-TLS/mbedtls#9223
and internal errors, but once I downgraded to 3.5.2 it worked instantly.
The rest is optimizations and improvements to move to 3.0+ but we'll still need to upgrade at some point to a higher version once they fix the issues.