Fix issue with keyboard navigation in emoji picker #9954

eVoloshchak · 2022-07-18T14:13:15Z

Details

The issue was happening due to incorrect calculation of firstNonHeaderIndex. The list of filtered emojis contained 2 * CONST.EMOJI_NUM_PER_ROW spacers and headers, while firstNonHeaderIndex was equal to CONST.EMOJI_NUM_PER_ROW in highlightAdjacentEmoji function. This PR makes it so firstNonHeaderIndex is calculated correctly every time list of emojis is updated.

Fixed Issues

$ #9728

Tests

Navigate to any chat
Open an emoji picker
Press arrow down
Verify that the first emoji is selected
Press arrow up
Verify that the search input is focused
Enter search phrase into the search input
Repeat steps 3 - 6

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Navigate to any chat
Open an emoji picker
Press arrow down
Verify that the first emoji is selected
Press arrow up
Verify that the search input is focused
Enter search phrase into the search input
Repeat steps 3 - 6

Screenshots

Web

cinnamon-20220718-2.mp4

Mobile Web

cinnamon-20220718-3.mp4

There is no search input on mWeb, so the behavior is unchanged

Desktop

I'm unable to launch the desktop app due to #8888 . It is not present if you downgrade to certain node and npm versions, but since I use MacinCloud, I'm unable to do so. So if someone with a mac could test it and upload a video, I would highly appreciate it.

iOS

External keyboards are not supported on native platforms, there is no logic for keyboard navigation in EmojiPickerMenu.native.js

Android

External keyboards are not supported on native platforms, there is no logic for keyboard navigation in EmojiPickerMenu.native.js

src/components/EmojiPicker/EmojiPickerMenu/index.js

rushatgabhane · 2022-07-21T04:23:45Z

src/components/EmojiPicker/EmojiPickerMenu/index.js

@@ -214,10 +225,13 @@ class EmojiPickerMenu extends Component {
     * @param {String} arrowKey
     */
    highlightAdjacentEmoji(arrowKey) {
-        const firstNonHeaderIndex = this.state.filteredEmojis.length === this.emojis.length ? this.numColumns : 0;
+        // Do nothing if there are no emojis to highlight


I don't think this comment is needed

rushatgabhane · 2022-07-21T04:24:44Z

src/components/EmojiPicker/EmojiPickerMenu/index.js

@@ -214,10 +225,13 @@ class EmojiPickerMenu extends Component {
     * @param {String} arrowKey
     */
    highlightAdjacentEmoji(arrowKey) {
-        const firstNonHeaderIndex = this.state.filteredEmojis.length === this.emojis.length ? this.numColumns : 0;
+        // Do nothing if there are no emojis to highlight
+        if (!this.state.filteredEmojis.length) {


I believe this describes it better

Suggested change

if (!this.state.filteredEmojis.length) {

if (this.state.filteredEmojis.length === 0) {

src/components/EmojiPicker/EmojiPickerMenu/index.js

rushatgabhane

@puneetlath LGTM!

PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

OSBotify · 2022-07-26T18:44:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-08-01T22:39:57Z

🚀 Deployed to staging by @puneetlath in version: 1.1.87-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-08-04T20:52:00Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Calculate firstNonHeaderIndex every time emoji list is updated

7126b70

eVoloshchak requested a review from a team as a code owner July 18, 2022 14:13

melvin-bot bot requested review from puneetlath and rushatgabhane and removed request for a team July 18, 2022 14:13

rushatgabhane reviewed Jul 20, 2022

View reviewed changes

src/components/EmojiPicker/EmojiPickerMenu/index.js Show resolved Hide resolved

eVoloshchak added 2 commits July 20, 2022 10:18

Do nothing if there are no emojis to highlight

33e0a17

Cleanup

0dd5d90

rushatgabhane suggested changes Jul 22, 2022

View reviewed changes

Cleanup

5c63ced

rushatgabhane approved these changes Jul 23, 2022

View reviewed changes

puneetlath approved these changes Jul 26, 2022

View reviewed changes

puneetlath merged commit e4ef5e2 into Expensify:main Jul 26, 2022

OSBotify mentioned this pull request Aug 1, 2022

Deploy Checklist: New Expensify 2022-08-01 #10169

Closed

95 tasks

kbecciv mentioned this pull request Aug 3, 2022

[$500] Web - Emoji - cursor is lost in animals & nature section #10223

Closed

melvin-bot bot mentioned this pull request Aug 4, 2022

[HOLD for payment 2022-08-11] [$250] Web - Moving to and from search bar to bottom emoji is inconsistent @daraksha-dk #9728

Closed

eVoloshchak mentioned this pull request Aug 5, 2022

[HOLD for payment 2022-08-30] [$250] Unable to move cursor (left/right) in searchbar - Reported by @daraksha-dk #10182

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue with keyboard navigation in emoji picker #9954

Fix issue with keyboard navigation in emoji picker #9954

eVoloshchak commented Jul 18, 2022 •

edited

Loading

rushatgabhane Jul 21, 2022

rushatgabhane Jul 21, 2022

eVoloshchak Jul 22, 2022

rushatgabhane left a comment

OSBotify commented Jul 26, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

	if (!this.state.filteredEmojis.length) {
	if (this.state.filteredEmojis.length === 0) {

Fix issue with keyboard navigation in emoji picker #9954

Fix issue with keyboard navigation in emoji picker #9954

Conversation

eVoloshchak commented Jul 18, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

rushatgabhane Jul 21, 2022

Choose a reason for hiding this comment

rushatgabhane Jul 21, 2022

Choose a reason for hiding this comment

eVoloshchak Jul 22, 2022

Choose a reason for hiding this comment

rushatgabhane left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 26, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

eVoloshchak commented Jul 18, 2022 •

edited

Loading