-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] fix links for Expensify Help site #9925
Conversation
Why can't this be QA'd? |
Ah the site is still in an "alpha" version and we're going to still do more changes, but this fix is required for us to internally begin to upload content. So I think it won't make sense to use QA since we're going to be testing the site internally until we have more content :) |
Merging it |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
I don't necessarily agree. As long as one of the QA testers can jump into the site and click the links I think its fine to have it go through the QA process since its not being cherry-picked. |
🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀
|
Details
This PR fixes the links for the new Expensify Help (where the back button is not working as expected here).
Fixed Issues
N/A
Tests
(you need ruby and bundler installed to do this, more info here)
Run:
Navigate to http://localhost:4000/articles/request-money/SmartScan and click on the
Back
button, it should redirect to the hub page (upper level)Home
button and verify it redirects you to the Homepage (currently it's an empty page) instead of the "Coming soon" page.