Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] fix links for Expensify Help site #9925

Merged
merged 4 commits into from
Jul 15, 2022
Merged

[NoQA] fix links for Expensify Help site #9925

merged 4 commits into from
Jul 15, 2022

Conversation

marcochavezf
Copy link
Contributor

Details

This PR fixes the links for the new Expensify Help (where the back button is not working as expected here).

Fixed Issues

N/A

Tests

  1. (you need ruby and bundler installed to do this, more info here)

  2. Run:

    cd docs
    bundle install
    bundle exec jekyll serve
  3. Navigate to http://localhost:4000/articles/request-money/SmartScan and click on the Back button, it should redirect to the hub page (upper level)

Screen Shot 2022-07-14 at 15 10 08

  1. Click on the Home button and verify it redirects you to the Homepage (currently it's an empty page) instead of the "Coming soon" page.

Screen Shot 2022-07-14 at 15 10 18

@marcochavezf marcochavezf requested a review from a team as a code owner July 14, 2022 20:13
@marcochavezf marcochavezf self-assigned this Jul 14, 2022
@melvin-bot melvin-bot bot requested review from johnmlee101 and removed request for a team July 14, 2022 20:13
@johnmlee101
Copy link
Contributor

Why can't this be QA'd?

@marcochavezf
Copy link
Contributor Author

Why can't this be QA'd?

Ah the site is still in an "alpha" version and we're going to still do more changes, but this fix is required for us to internally begin to upload content. So I think it won't make sense to use QA since we're going to be testing the site internally until we have more content :)

@marcochavezf
Copy link
Contributor Author

Merging it

@marcochavezf marcochavezf merged commit d2c03dc into main Jul 15, 2022
@marcochavezf marcochavezf deleted the marco-fixLinks branch July 15, 2022 17:10
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@johnmlee101
Copy link
Contributor

I don't necessarily agree. As long as one of the QA testers can jump into the site and click the links I think its fine to have it go through the QA process since its not being cherry-picked.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants