-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename chat.expensify.com to expensify.cash in display names #975
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There are going to be a million merge conflicts on this branch due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well, approving so we can fix conflicts and merge
@@ -1,4 +1,4 @@ | |||
rootProject.name = 'ReactNativeChat' | |||
rootProject.name = 'ExpensifyCash' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker but we could also do ExpensifyDotCash
to mimic how we say usedot
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we also going to rename this repo?
Yes we are! In https://github.com/Expensify/Expensify/issues/147628 has all the details. @bondydaa - Can you try something for me? Check out |
I think somethings off with my cocoapods
|
I confirmed this worked with @marcaaron via DM, so yes I agree it might be a cocoapod issue |
Please review @Jag96
Renaming all the clients display names to
Expensify.cash
. In some spots, we can't use the.
or a space so I was required to useExpensifyCash
. This is going to be an ongoing battle to update everything, so I mainly focused on making sure the end product had the right name, instead of worry about every instance or mention in code.Fixed Issues
Last check box from https://github.com/Expensify/Expensify/issues/147628#issuecomment-744999420
Tests
I ran this across all platforms and made sure the display name said
Expensify.cash
, I have included screenshots of all examples.Screenshots
iOS
Android
Desktop
Web