Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename chat.expensify.com to expensify.cash in display names #975

Merged
merged 8 commits into from
Dec 16, 2020

Conversation

AndrewGable
Copy link
Contributor

Please review @Jag96

Renaming all the clients display names to Expensify.cash. In some spots, we can't use the . or a space so I was required to use ExpensifyCash. This is going to be an ongoing battle to update everything, so I mainly focused on making sure the end product had the right name, instead of worry about every instance or mention in code.

Fixed Issues

Last check box from https://github.com/Expensify/Expensify/issues/147628#issuecomment-744999420

Tests

I ran this across all platforms and made sure the display name said Expensify.cash, I have included screenshots of all examples.

Screenshots

iOS

Screen Shot 2020-12-15 at 3 50 50 PM

Android

Screen Shot 2020-12-15 at 4 18 36 PM

Desktop

Screen Shot 2020-12-15 at 4 26 36 PM

Screen Shot 2020-12-15 at 4 32 17 PM

Screen Shot 2020-12-15 at 4 43 50 PM

Screen Shot 2020-12-15 at 4 43 58 PM

Screen Shot 2020-12-15 at 4 46 17 PM

Screen Shot 2020-12-15 at 4 46 14 PM

Web

Screen Shot 2020-12-15 at 4 27 43 PM

@AndrewGable AndrewGable requested a review from a team as a code owner December 16, 2020 00:32
@AndrewGable AndrewGable self-assigned this Dec 16, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2020

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@botify botify requested review from bondydaa and removed request for a team and bondydaa December 16, 2020 00:32
@AndrewGable
Copy link
Contributor Author

There are going to be a million merge conflicts on this branch due to package.json changes, so once it's approved I can fix them right before a merge

Jag96
Jag96 previously approved these changes Dec 16, 2020
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well, approving so we can fix conflicts and merge

@@ -1,4 +1,4 @@
rootProject.name = 'ReactNativeChat'
rootProject.name = 'ExpensifyCash'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker but we could also do ExpensifyDotCash to mimic how we say usedot.

bondydaa
bondydaa previously approved these changes Dec 16, 2020
Copy link
Contributor

@bondydaa bondydaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we also going to rename this repo?

@AndrewGable
Copy link
Contributor Author

Yes we are! In https://github.com/Expensify/Expensify/issues/147628 has all the details.

@bondydaa - Can you try something for me? Check out master, make sure it's up to date, then check out this branch. Run npm install && cd ios && pod install then run npm run ios. Let me know if it does or doesn't work, thanks!

@bondydaa
Copy link
Contributor

I think somethings off with my cocoapods

dbondy/Expensidev (master) $ git clone git@github.com:Expensify/ReactNativeChat.git
Cloning into 'ReactNativeChat'...
remote: Enumerating objects: 215, done.
remote: Counting objects: 100% (215/215), done.
remote: Compressing objects: 100% (157/157), done.
remote: Total 28564 (delta 119), reused 117 (delta 57), pack-reused 28349
Receiving objects: 100% (28564/28564), 11.04 MiB | 6.03 MiB/s, done.
Resolving deltas: 100% (21054/21054), done.
dbondy/Expensidev (master) $ cd ReactNativeChat/
Expensidev/ReactNativeChat (master) $ git checkout andrew-rename-cash
Branch 'andrew-rename-cash' set up to track remote branch 'andrew-rename-cash' from 'origin'.
Switched to a new branch 'andrew-rename-cash'
Expensidev/ReactNativeChat (andrew-rename-cash) $ npm install && cd ios && pod install

> dtrace-provider@0.8.8 install /Users/dbondy/Expensidev/ReactNativeChat/node_modules/dtrace-provider
> node-gyp rebuild || node suppress-error.js

  ACTION binding_gyp_ndtp_target_build_ndtp .
-----------------------------------------------------------------
Building dtrace-provider failed with exit code 1, falling back
on stub implementation.

Re-run install with V set in your environment to see the build
output, or NODE_DTRACE_PROVIDER_REQUIRE=hard to force an
installation failure.
-----------------------------------------------------------------
  TOUCH Release/obj.target/ndtp.stamp

> fsevents@1.2.13 install /Users/dbondy/Expensidev/ReactNativeChat/node_modules/fsevents
> node install.js

  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node

> core-js@2.6.11 postinstall /Users/dbondy/Expensidev/ReactNativeChat/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)


> core-js@3.6.5 postinstall /Users/dbondy/Expensidev/ReactNativeChat/node_modules/global-agent/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"


> detox@17.10.2 postinstall /Users/dbondy/Expensidev/ReactNativeChat/node_modules/detox
> node scripts/postinstall.js

Extracting Detox framework...
Done

> electron@9.3.2 postinstall /Users/dbondy/Expensidev/ReactNativeChat/node_modules/electron
> node install.js

added 2651 packages from 1100 contributors and audited 2657 packages in 95.063s

112 packages are looking for funding
  run `npm fund` for details

found 21 vulnerabilities (17 low, 4 moderate)
  run `npm audit fix` to fix them, or `npm audit` for details
Using firebase.json from '/Users/dbondy/Expensidev/ReactNativeChat/firebase.json'
Adding a custom script phase for Pod RNFBApp: [RNFB] Core Configuration
Adding a custom script phase for Pod RNFBCrashlytics: [RNFB] Crashlytics Configuration
++ dirname /Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts/sync_version.sh
+ SCRIPT_DIRECTORY=/Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts
++ dirname /Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts/sync_version.sh
+ ROOT_PATH=/Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts/../
+ VERSION=9.0.1
+ '[' -z 9.0.1 ']'
+ sed -i '' 's/\(airshipModuleVersionString *= *@\)".*"/\1"9.0.1"/g' ios/UARCTModule/UARCTModuleVersion.m
Auto-linking React Native modules for target `ExpensifyCash`: RNCAsyncStorage, RNCPushNotificationIOS, RNFBAnalytics, RNFBApp, RNFBCrashlytics, react-native-config, react-native-document-picker, react-native-image-picker, react-native-netinfo, react-native-pdf, react-native-progress-bar-android, react-native-progress-view, react-native-safe-area-context, react-native-webview, rn-fetch-blob, and urbanairship-react-native
Analyzing dependencies
[!] The version of CocoaPods used to generate the lockfile (1.10.0) is higher than the version of the current executable (1.9.3). Incompatibility issues may arise.
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `Folly` from `../node_modules/react-native/third-party-podspecs/Folly.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
++ dirname /Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts/sync_version.sh
+ SCRIPT_DIRECTORY=/Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts
++ dirname /Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts/sync_version.sh
+ ROOT_PATH=/Users/dbondy/Expensidev/ReactNativeChat/node_modules/urbanairship-react-native/scripts/../
+ VERSION=9.0.1
+ '[' -z 9.0.1 ']'
+ sed -i '' 's/\(airshipModuleVersionString *= *@\)".*"/\1"9.0.1"/g' ios/UARCTModule/UARCTModuleVersion.m
Cloning spec repo `trunk` from `https://cdn.cocoapods.org/`
[!] Unable to add a source with url `https://cdn.cocoapods.org/` named `trunk`.
You can try adding it manually in `/Users/dbondy/.cocoapods/repos` or via `pod repo add`.

@AndrewGable
Copy link
Contributor Author

I confirmed this worked with @marcaaron via DM, so yes I agree it might be a cocoapod issue

@rafecolton rafecolton merged commit 508d034 into master Dec 16, 2020
@rafecolton rafecolton deleted the andrew-rename-cash branch December 16, 2020 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants