Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using MY_PERSONAL_DETAILS and only use PERSONAL_DETAILS in Onyx #9560

Merged
merged 40 commits into from
Jul 16, 2022
Merged

Stop using MY_PERSONAL_DETAILS and only use PERSONAL_DETAILS in Onyx #9560

merged 40 commits into from
Jul 16, 2022

Commits on Jun 24, 2022

  1. Refactor AuthScreens.js to use PERSONAL_DETAILS instead of MY_PERSONA… 

    …L_DETAILS
    @puneetlath
    puneetlath committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1a05abf View commit details
    Browse the repository at this point in the history

  2. Flag wich details in the personalDetails object belong to the current… 

    … user
    @puneetlath
    puneetlath committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    8b67fd9 View commit details
    Browse the repository at this point in the history

  3. Update AuthScreen.js to look for new isCurrentUser flag

    @puneetlath
    puneetlath committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    98092d7 View commit details
    Browse the repository at this point in the history

  4. Update Report.js to use PERSONAL_DETAILS instead of MY_PERSONAL_DETAILS

    @puneetlath
    puneetlath committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    09fe20d View commit details
    Browse the repository at this point in the history

  5. Replace semicolon that was supposed to be comma

    @puneetlath
    puneetlath committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    413872f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Refactor ReportActionCompose.js to use PERSONAL_DETAILS instead of MY… 

    …_PERSONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    dc7170b View commit details
    Browse the repository at this point in the history

  2. Refactor RequestCallPage.js to use PERSONAL_DETAILS instead of MY_PER… 

    …SONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    630e90e View commit details
    Browse the repository at this point in the history

  3. Refactor DateUtils.js to use PERSONAL_DETAILS instead of MY_PERSONAL_… 

    …DETAILS
    @puneetlath
    puneetlath committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    c6a6d82 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Refactor EnablePayments.js to use PERSONAL_DETAILS instead of MY_PERS… 

    …ONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    9aa4772 View commit details
    Browse the repository at this point in the history

  2. Refactor IOUModal.js to use PERSONAL_DETAILS instead of MY_PERSONAL_D… 

    …ETAILS
    @puneetlath
    puneetlath committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    a65ca25 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Refactor IOUCurrencySelection.js to use PERSONAL_DETAILS instead of M… 

    …Y_PERSONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c3ba3b0 View commit details
    Browse the repository at this point in the history

  2. Refactor SidebarLinks.js to use PERSONAL_DETAILS instead of MY_PERSON… 

    …AL_DETAILS
    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    b1a1eb7 View commit details
    Browse the repository at this point in the history

  3. Refactor ProfilePage.js to use PERSONAL_DETAILS instead of MY_PERSONA… 

    …L_DETAILS
    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    dc7a183 View commit details
    Browse the repository at this point in the history

  4. Remove no longer used currentUserPersonalDetailsPropsTypes

    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    b035b1d View commit details
    Browse the repository at this point in the history

  5. Refactor InitialSettingsPage.js to use PERSONAL_DETAILS instead of MY… 

    …_PERSONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    5f9bf56 View commit details
    Browse the repository at this point in the history

  6. Refactor IOUConfirmationList.js to use PERSONAL_DETAILS instead of MY… 

    …_PERSONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    b005095 View commit details
    Browse the repository at this point in the history

  7. No longer save to MY_PERSONAL_DETAILS key in fetchPersonalDetails method

    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    22e1150 View commit details
    Browse the repository at this point in the history

  8. Refactor PersonalDetails.js to use PERSONAL_DETAILS instead of MY_PER… 

    …SONAL_DETAILS
    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    085ed98 View commit details
    Browse the repository at this point in the history

  9. Remove the MY_PERSONAL_DETAILS onyx key

    @puneetlath
    puneetlath committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    380dbaf View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Merge branch 'main' into puneet-personaldetails-refactor

    @puneetlath
    puneetlath authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    3d37ef3 View commit details
    Browse the repository at this point in the history

  2. Get rid of unnecessary personal details references from IOUCurrencySe… 

    …lection.js
    @puneetlath
    puneetlath committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    67e1fd5 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Create HOC for withPersonalDetails

    @puneetlath
    puneetlath committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    8aec239 View commit details
    Browse the repository at this point in the history

  2. Add session prop and proptype to personal details HOC

    @puneetlath
    puneetlath committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    31ab939 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. rename withPersonalDetails to withCurrentUserPersonalDetails

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    1def41d View commit details
    Browse the repository at this point in the history

  2. update withCurrentUserPersonalDetails to pass single prop of current … 

    …users details
    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    00bd238 View commit details
    Browse the repository at this point in the history

  3. update RequestCallPage to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    afa27df View commit details
    Browse the repository at this point in the history

  4. update ReportActionCompose to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    6fc8e92 View commit details
    Browse the repository at this point in the history

  5. update Report.js to use current user email instead of current user flag

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    a6fbd64 View commit details
    Browse the repository at this point in the history

  6. update AdditionalDetailsStep to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    59168f3 View commit details
    Browse the repository at this point in the history

  7. update IOUModal to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    55568ac View commit details
    Browse the repository at this point in the history

  8. update InitialSettingsPage to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    cd60eca View commit details
    Browse the repository at this point in the history

  9. update SidebarLinks to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    83ae808 View commit details
    Browse the repository at this point in the history

  10. update IOUConfirmationList to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    92a6cbb View commit details
    Browse the repository at this point in the history

  11. update ProfilePage to use withCurrentUserPersonalDetails HOC

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    e6bbd9c View commit details
    Browse the repository at this point in the history

  12. update DateUtils to use current user email instead of current user flag

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    c9e4421 View commit details
    Browse the repository at this point in the history

  13. use lodash get instead of new variable for current user

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    6f371c0 View commit details
    Browse the repository at this point in the history

  14. update AuthScreens to use current user email instead of current user … 

    …flag
    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    58f74c8 View commit details
    Browse the repository at this point in the history

  15. dont flag the current user details in personal details

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    ccb9d27 View commit details
    Browse the repository at this point in the history

  16. Add more values to personal details prop type

    @puneetlath
    puneetlath committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0deaba4 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into puneet-personaldetails-refactor

    @puneetlath
    puneetlath authored Jul 15, 2022
    Configuration menu
    Copy the full SHA
    972c310 View commit details
    Browse the repository at this point in the history