Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "trying different styles" and updating react-navigation #8912

Merged
merged 2 commits into from
May 10, 2022

Conversation

chiragsalian
Copy link
Contributor

This reverts commit ff2636e.

Details

Fixed Issues

#8791

Tests

None. A revert.

@chiragsalian chiragsalian requested a review from a team as a code owner May 10, 2022 01:58
@chiragsalian chiragsalian self-assigned this May 10, 2022
@melvin-bot melvin-bot bot requested review from madmax330 and removed request for a team May 10, 2022 01:58
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@chiragsalian chiragsalian changed the title Revert "trying different styles" Revert "trying different styles" and updating react-navigation May 10, 2022
@chiragsalian chiragsalian changed the title Revert "trying different styles" and updating react-navigation [WIP] Revert "trying different styles" and updating react-navigation May 10, 2022
@chiragsalian chiragsalian changed the title [WIP] Revert "trying different styles" and updating react-navigation Revert "trying different styles" and updating react-navigation May 10, 2022
@chiragsalian chiragsalian merged commit 88f1784 into main May 10, 2022
@chiragsalian chiragsalian deleted the chirag-revert-styles branch May 10, 2022 02:34
OSBotify pushed a commit that referenced this pull request May 10, 2022
Revert "trying different styles" and updating react-navigation

(cherry picked from commit 88f1784)
OSBotify added a commit that referenced this pull request May 10, 2022
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.57-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@chiragsalian
Copy link
Contributor Author

Still didn't work, on staging first screen,
image

once workspace is clicked,
image

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants