Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Simplify electron-builder configs #7684

Merged
merged 16 commits into from
Feb 14, 2022
Merged

[No QA] Simplify electron-builder configs #7684

merged 16 commits into from
Feb 14, 2022

Commits on Feb 10, 2022

  1. Move afterSign to electron.config.js

    @roryabraham
    roryabraham committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    27afd80 View commit details
    Browse the repository at this point in the history

  2. Split apart local build and publishing pieces to make local prod/stag… 

    …ing builds easier
    @roryabraham
    roryabraham committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    d126a85 View commit details
    Browse the repository at this point in the history

  3. Pass NODE_ENV explicitly in package.json instead of relying on an env… 

    …ironment variable from GitHub Actions
    @roryabraham
    roryabraham committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    4c1b388 View commit details
    Browse the repository at this point in the history

  4. Delete now-unused electron.config.js

    @roryabraham
    roryabraham committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    87837c0 View commit details
    Browse the repository at this point in the history

  5. Fix import and electronBuilder configs?

    @roryabraham
    roryabraham committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    a9a9666 View commit details
    Browse the repository at this point in the history

  6. Update documentation

    @roryabraham
    roryabraham committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    63c282e View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Add NODE_ENV=production to package.json scripts

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    ca73ad8 View commit details
    Browse the repository at this point in the history

  2. Rename electronBuilder configs

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    3419249 View commit details
    Browse the repository at this point in the history

  3. Move NODE_ENV dev to package.json

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    f880d0a View commit details
    Browse the repository at this point in the history

  4. Rename environment constant to standardize on the longer form

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    6ae2075 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into Rory-LessConfusingDesktopEnvironments

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8978c94 View commit details
    Browse the repository at this point in the history

  6. Update dotenv environment to match long form

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    61d5361 View commit details
    Browse the repository at this point in the history

  7. Fix environment badge

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    0d3aaf6 View commit details
    Browse the repository at this point in the history

  8. Move desktop script to be with other desktop scripts

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    481bb3d View commit details
    Browse the repository at this point in the history

  9. Cleanup local variables in electronBuilder configs

    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    86a8fbd View commit details
    Browse the repository at this point in the history

  10. Rename NODE_ENV to ELECTRON_ENV to prevent problems in 3rd party pack… 

    …ages
    @roryabraham
    roryabraham committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    890bdf1 View commit details
    Browse the repository at this point in the history