Revert "Separate report name and icon configuration from personal details" #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luacmartins
approved these changes
Feb 8, 2022
|
|
OSBotify
pushed a commit
that referenced
this pull request
Feb 8, 2022
Revert "Separate report name and icon configuration from personal details" (cherry picked from commit b55663a)
This was referenced Feb 8, 2022
|
🚀 Cherry-picked to staging by @luacmartins in version: 1.1.37-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀
|
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7453
My investigation leads to #7453 causing a big regression resulting in a near-infinite loop, so the first step I need to do is rule out this refactoring.