Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing PayPal account when trying to delete it #7571

Merged
merged 5 commits into from
Feb 9, 2022
Merged

Fix: Missing PayPal account when trying to delete it #7571

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50bd821
check web platform
ahmdshrif Feb 4, 2022
0c54037
check popover mount postion
ahmdshrif Feb 6, 2022
624aabb
fix isPopoverBottomMount
ahmdshrif Feb 6, 2022
e73f0b2
add comment to isPopoverBottomMount
ahmdshrif Feb 8, 2022
4673bf5
update comment
ahmdshrif Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/settings/Payments/PaymentsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ class PaymentsPage extends React.Component {

render() {
const isPayPalMeSelected = this.state.formattedSelectedPaymentMethod.type === CONST.PAYMENT_METHODS.PAYPAL;

// determine if the popover appears from the bottom of the screen or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for a more detailed comment, something along the lines of
Determines whether or not the modal popup is mounted from the bottom of the screen instead of the side mount on Web or Desktop screens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better, i update it now

const isPopoverBottomMount = this.state.anchorPositionTop === 0 || this.props.isSmallScreenWidth;
return (
<ScreenWrapper>
<KeyboardAvoidingView>
Expand Down Expand Up @@ -290,7 +293,7 @@ class PaymentsPage extends React.Component {
!this.props.isSmallScreenWidth ? styles.sidebarPopover : '',
]}
>
{this.props.isSmallScreenWidth && (
{isPopoverBottomMount && (
<MenuItem
title={this.state.formattedSelectedPaymentMethod.title}
icon={this.state.formattedSelectedPaymentMethod.icon}
Expand Down